npawar commented on pull request #5326:
URL: https://github.com/apache/incubator-pinot/pull/5326#issuecomment-623588587


   > > Question: how would y'all test something like this locally? I ran the 
immediately relevant tests in IntelliJ, then triggered a `mvn test` (still 
running a while later). What command would y'all run to feel confident?
   > 
   > You could
   > 
   > 1. create a sample test file, and a schema with your transform functions
   > 2. create a segment w/ your schema and data
   > 3. read the segment using PinotSegmentRecordReader, verify values OR load 
the segment in a local setup and query
   
   Would also be nice to have an integration test, specifically designed to 
test transform functions. We could have groovy, static date time, non-static 
date time functions. This can be a followup PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to