mcvsubbu commented on a change in pull request #5314:
URL: https://github.com/apache/incubator-pinot/pull/5314#discussion_r419558050
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/SplitSegmentCommitter.java
##########
@@ -35,16 +38,34 @@
private final ServerSegmentCompletionProtocolHandler _protocolHandler;
private final IndexLoadingConfig _indexLoadingConfig;
private final SegmentUploader _segmentUploader;
+ // The default segment location uri str, could be null.
+ private final String _defaultSegmentLocation;
private final Logger _segmentLogger;
public SplitSegmentCommitter(Logger segmentLogger,
ServerSegmentCompletionProtocolHandler protocolHandler,
IndexLoadingConfig indexLoadingConfig,
SegmentCompletionProtocol.Request.Params params, SegmentUploader
segmentUploader) {
+ this(segmentLogger, protocolHandler, indexLoadingConfig, params,
segmentUploader, null);
+ }
+
+ /**
+ *
+ * @param segmentLogger
+ * @param protocolHandler
+ * @param indexLoadingConfig
+ * @param params
+ * @param segmentUploader
+ * @param defaultSegmentLocation The default segment location uri str, could
be null.
+ */
+ public SplitSegmentCommitter(Logger segmentLogger,
ServerSegmentCompletionProtocolHandler protocolHandler,
+ IndexLoadingConfig indexLoadingConfig,
SegmentCompletionProtocol.Request.Params params, SegmentUploader
segmentUploader,
+ String defaultSegmentLocation) {
Review comment:
Ah, the config isEnableSplitCommitEndWithMetadata can re removed now. We
had introduced that for upgrade compatibility. by now, the controllers should
already have the capability to get split commit with metadata.
So, you can remove that, and then, like you pointed out, remove tableConfig
as well (for some reason, I thought tableConfig had that boolean. my bad, sorry)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
