xiangfu0 commented on code in PR #19032:
URL: https://github.com/apache/pinot/pull/19032#discussion_r3680633993
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/invertedindex/H3IndexHandler.java:
##########
@@ -215,7 +214,10 @@ private void
handleDictionaryBasedColumn(SegmentDirectory.Writer segmentWriter,
int numDocs = columnMetadata.getTotalDocs();
for (int i = 0; i < numDocs; i++) {
int dictId = forwardIndexReader.getDictId(i, readerContext);
-
h3IndexCreator.add(GeometrySerializer.deserialize(dictionary.getBytesValue(dictId)));
+ // Route through add(value, dictId) so that empty/default geometry
values (e.g. old segments reloaded after
+ // the geo column was added, which have no source data to build a
Point from) are tolerated the same way the
+ // segment-creation path tolerates them, instead of failing the whole
reload with a BufferUnderflowException.
+ h3IndexCreator.add(dictionary.getBytesValue(dictId), dictId);
Review Comment:
I think there is no caller for `void add(@Nullable Geometry geometry)`
anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
