Vamsi-klu opened a new pull request, #19025: URL: https://github.com/apache/pinot/pull/19025
## Summary Aligns source comments and the ingestion job-spec YAML template with real PathMatcher behavior (glob **or** regex, whole path, URI normalization). **No runtime behavior change.** **Issues:** Related to apache/pinot#8192 / apache/pinot#10611 (docs PR lands in pinot-docs) --- ## What is the problem? Even after docs fixes, in-tree comments and the job-spec template still said “glob only” or showed fragile patterns. Contributors copy those comments back into docs and samples, reintroducing the same wrong guidance (#10611/#8192). --- ## Why did I do this? Comment/template drift is how incorrect path-matcher guidance keeps returning. A small comment-only PR keeps source and docs consistent without mixing behavioral changes. --- ## What is the implementation edit? | File | Change | |------|--------| | `pinot-spi/.../SegmentGenerationJobSpec.java` | Javadoc: PathMatcher, Java regex, normalization, templating | | `pinot-spi/.../ingestion_job_spec_template.yaml` | Matching comments / example patterns | | `pinot-common/.../SegmentGenerationUtils.java` | Param docs: glob or regex PathMatcher; typo `ture` → `true` | | `pinot-plugins/.../SegmentGenerationAndPushTaskGenerator.java` | Comment that include/exclude accept glob+regex | No matching logic changes. --- ## What is the impact? - **Contributors:** Less likely to reintroduce glob-only docs. - **Runtime:** None. - **Risk:** Minimal (comments/docs in source only). --- ## What is the testing edit? - No new tests (comment-only). - Spotless/license not strictly required for comments but PR should pass Apache checks. - Behavioral docs validated separately in pinot-docs PRs. --- ## Checklist - [x] Draft - [x] No behavior change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
