xiangfu0 commented on code in PR #19010:
URL: https://github.com/apache/pinot/pull/19010#discussion_r3607768928
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/ConsumingSegmentConsistencyModeListener.java:
##########
@@ -59,7 +60,7 @@ public enum Mode {
*/
UNSAFE(true);
- public static final Mode DEFAULT_CONSUMING_SEGMENT_CONSISTENCY_MODE =
RESTRICTED;
+ public static final Mode DEFAULT_CONSUMING_SEGMENT_CONSISTENCY_MODE =
PROTECTED;
Review Comment:
This changes the released cluster-wide default from `RESTRICTED` to
`PROTECTED` in `pinot-spi`. Deployments that never set
`pinot.server.consuming.segment.consistency.mode` would now allow
force-commit/reload on partial-upsert or `dropOutOfOrderRecord` tables and run
the metadata-revert path by default. Keep the Apache default `RESTRICTED`, or
make `PROTECTED` an explicit cluster config/upgrade opt-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
