Jackie-Jiang commented on code in PR #19003:
URL: https://github.com/apache/pinot/pull/19003#discussion_r3598781820
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java:
##########
@@ -165,7 +174,7 @@ private static ImmutableTableOptions
overridePartitionKey(ImmutableTableOptions
*/
private static ImmutableTableOptions
overridePartitionFunction(ImmutableTableOptions base,
TableScan tableScan, Map<String, String> kvOptions) {
- String partitionFunction =
kvOptions.get(kvOptions.get(PinotHintOptions.TableHintOptions.PARTITION_FUNCTION));
Review Comment:
lol + 1
##########
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotImplicitTableHintRule.java:
##########
@@ -152,7 +161,7 @@ private static TableOptions calculateTableOptions(
*/
private static ImmutableTableOptions
overridePartitionKey(ImmutableTableOptions base, TableScan tableScan,
Map<String, String> kvOptions) {
- String partitionKey =
kvOptions.get(kvOptions.get(PinotHintOptions.TableHintOptions.PARTITION_KEY));
Review Comment:
lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
