xiangfu0 commented on PR #18996: URL: https://github.com/apache/pinot/pull/18996#issuecomment-4990254170
Reducer/group-by follow-up is now pushed in b7b01bd667. Benchmark highlights (TDigest 3.2, 2 forks × 5 measurements): - Representative full IndexedTable combine, 32-way fan-in: 0.2683 ms pairwise → 0.0340 ms promoted local (7.90×), 0.0201 ms accumulator-local (13.33×), and 0.0233 ms serialized/wire (11.52×). - Production-shaped 1,440 groups × 7 metrics × 32 segments: 4,574.4 ± 309.3 ms pairwise → 223.0 ± 2.3 ms accumulator-local (20.51×) and 283.0 ± 6.2 ms wire (16.16×). Allocation fell 93.87% and 92.22%. - The 36 workload shapes × 4 implementations retained exact weight, finite positive centroids, monotonic quantiles, and standard TDigest 3.2 wire bytes. Maximum sampled P75 error was 0.001353 pairwise versus 0.000709 for the primitive candidates. - The dependency-only TDigest 3.3 experiment was a no-go despite a 4.47× kernel geometric-mean speedup: mean P75 error increased 18.9× and the maximum sampled error reached 0.01138. The full report and reproduction commands are in pinot-perf/benchmark-results/percentile-aggregation-100m-results.md. Validation: 318 focused reducer/serde/concurrency tests passed; the 64-module warning-enabled test compilation passed (921 goals); spotless, checkstyle, license format/check, and diff-check all pass. New CI is running on this head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
