xiangfu0 commented on PR #18972: URL: https://github.com/apache/pinot/pull/18972#issuecomment-4988254434
Follow-up on the `earlyExit` naming: implemented distinct names instead of the positional boolean, per the naming/config-backcompat reviewers. - `jsonPathStringFast` / `jsonPathLongFast` / `jsonPathDoubleFast` — streaming, full scan, **same result** as the existing `jsonPath*` (Jayway). - `jsonPathStringFirstMatch` / … — streaming, stops at the first match; the two divergences (duplicate-key first-wins, malformed-tail tolerated) are now signalled by the name rather than an unlabeled `true`. Also fixed the integration test: these take an `Object` arg, so (like `jsonPathString`) they run through **ingestion transform configs**, not query-time SELECT — a query-time call hits `Unsupported parameter type: OBJECT` in `ScalarTransformFunctionWrapper`. `JsonPathTest` now derives columns with the new functions at ingestion and checks them against the Jayway-derived column on both engines. Names are still your call — easy to adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
