Vamsi-klu commented on PR #18483: URL: https://github.com/apache/pinot/pull/18483#issuecomment-4966078425
The stream lifetime here checks out: `withIdentityMaterial(InputStream, ...)` and `withTrustMaterial(InputStream, ...)` read the stream into a `KeyStore` right at the call, so closing inside the tightened `try` block instead of after `build()` loses nothing on the success path, and it actually closes the fd on the paths where the trust store `openStream()` or `build()` used to throw before the old close ran. Nice that it lines up with the try-with-resources `TlsUtils.createKeyManagerFactory` already uses a few methods over in the same package. Happy to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
