Vamsi-klu commented on PR #18512: URL: https://github.com/apache/pinot/pull/18512#issuecomment-4966078320
Nice catch. In `SchemaUtils.validate` the old `checkState` was passing `transformedColumns.retainAll(argumentColumns)` (a boolean) into the `%s` slot, so on the failure path where the sets overlap `retainAll` returns `true` and you got "Columns: true are a result of transformations...". Copying into `chainedTransformColumns` and gating on `isEmpty()` is the same condition as the old `Collections.disjoint` check (disjoint is true exactly when the intersection is empty), it just stops mutating `transformedColumns` and hands the message the real column names, and `testChainedTransformErrorMessageListsConflictingColumns` pins the deterministic `[x]`. Also checked that the dropped `java.util.Collections` import had no other use in the file. Minor and non blocking, the inline comment and the test javadoc both re-explain the old boolean bug so it's a touch redundant, but I'd leave it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
