Vamsi-klu commented on PR #18774: URL: https://github.com/apache/pinot/pull/18774#issuecomment-4966077990
Walked through the three guards in `validateStarTreeIndexConfigs`: the first-loop `indexConfigsMap.get(dimension)` dictionary check, the `Iterables.concat` MAP check, and the `dimensionColumns` single-value check now all short circuit when the column is in `timestampIndexColumns`, so `$OrderDate$DAY` no longer trips the `Failed to find dimension column` precondition. I like that the allowed set comes from `extractColumnsWithGranularity` rather than an `isValidColumnWithGranularity` shape match, since that's exactly what keeps `$OrderDate$HOUR` in the negative test rejected instead of blanket accepted (HOUR is a valid granularity token but was never declared on `OrderDate`). It also lines up with what `applyTimestampIndex` materializes into the schema at segment build time, so config validation and runtime agree. One note: the derived branch skips the dictionary precondition too, which reads fine since these get generated as dictionary encoded. This looks right to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
