Vamsi-klu commented on PR #18974:
URL: https://github.com/apache/pinot/pull/18974#issuecomment-4965893512
@xiangfu0 thanks for asking for the UI screenshot. I captured this from the
latest PR branch/commit.
### Screenshot proof
1. **Swagger UI uses the generated Pinot Controller spec**
- Shows: live Pinot Controller Swagger UI loaded from `/swagger.json`,
with the `Authorize` control visible.
- Addresses: request for UI screenshot of the testing.
- Screenshot: 
2. **Authorize dialog exposes the Authorization header**
- Shows: `oauth (apiKey)` with `Name: Authorization` and `In: header`; no
real token is entered.
- Addresses: verifies the generated security definition is visible
through the UI.
- Screenshot: 
### Validation
- Branch/commit: `fix-swagger-auth-security-definition` /
`2906acca573707ddc5735e3c2ca75753e171fbb1`
- Browser/viewport: `Chromium, 1440x1100`
- Manual flow: `pinot-tools quick-start-batch ->
http://localhost:9000/api?url=/swagger.json -> Authorize`
- Local check: `./mvnw -pl pinot-common -Dtest=SwaggerSetupUtilsTest test`
passed (`1` test)
- Package/runtime check: `./mvnw -pl pinot-tools -am package -DskipTests`
passed, and the packaged quickstart served the UI
- API payload check: `curl -fsS http://localhost:9000/swagger.json | jq
'.securityDefinitions.oauth'` showed `type: apiKey`, `name: Authorization`,
`in: header`; endpoint security includes `oauth` (`242` operations, including
`/users`)
- CI: current PR checks are passing (`11` listed checks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
