tarun11Mavani commented on code in PR #18368:
URL: https://github.com/apache/pinot/pull/18368#discussion_r3328508523
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/ComplexFieldSpec.java:
##########
@@ -56,8 +58,17 @@ public final class ComplexFieldSpec extends FieldSpec {
public static final String KEY_FIELD = "key";
public static final String VALUE_FIELD = "value";
+ /// Default {@code defaultValueFieldSpec} used for {@link
DataType#OPEN_STRUCT} columns when
+ /// the schema does not declare one explicitly. Keys with no per-key type
hint are stored as
+ /// single-value STRING.
+ public static final FieldSpec DEFAULT_OPEN_STRUCT_VALUE_FIELD_SPEC =
+ new DimensionFieldSpec("default", DataType.STRING, true);
+
private final Map<String, FieldSpec> _childFieldSpecs;
+ @Nullable
+ private FieldSpec _defaultValueFieldSpec;
Review Comment:
I started with defining the defaultFieldSpec for all columns that are not
defined in childFieldSpec but auto inferring makes more sense.
Removing the new field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
