Jackie-Jiang commented on code in PR #18510:
URL: https://github.com/apache/pinot/pull/18510#discussion_r3277881319
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -507,6 +507,16 @@ public static class Broker {
public static final String CONFIG_OF_IGNORE_MISSING_SEGMENTS =
"pinot.broker.query.ignore.missing.segments";
public static final boolean DEFAULT_IGNORE_MISSING_SEGMENTS = false;
+
+ /**
+ * Default flush threshold for the streaming group-by leaf-stage operator
on MSE. When {@code > 0}, the broker
+ * injects this value as the {@link
Request.QueryOptionKey#STREAMING_GROUP_BY_FLUSH_THRESHOLD} query option for
+ * MSE queries that do not already specify it, opting the cluster into the
streaming group-by behavior by default.
+ * Setting the query option explicitly (including to {@code 0} to disable)
always wins over the broker default.
+ */
+ public static final String
CONFIG_OF_MSE_STREAMING_GROUP_BY_FLUSH_THRESHOLD =
+ "pinot.broker.mse.streaming.group.by.flush.threshold";
+ public static final int DEFAULT_MSE_STREAMING_GROUP_BY_FLUSH_THRESHOLD = 0;
Review Comment:
`-1` is usually more clear that it is disabled
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -507,6 +507,16 @@ public static class Broker {
public static final String CONFIG_OF_IGNORE_MISSING_SEGMENTS =
"pinot.broker.query.ignore.missing.segments";
public static final boolean DEFAULT_IGNORE_MISSING_SEGMENTS = false;
+
+ /**
Review Comment:
(minor) Markdown style is more readable (no need of `@code` or `@link`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
