xiangfu0 commented on code in PR #18482:
URL: https://github.com/apache/pinot/pull/18482#discussion_r3252779678
##########
pinot-common/src/main/proto/plan.proto:
##########
@@ -251,6 +260,7 @@ message WindowNode {
int32 lowerBound = 5;
int32 upperBound = 6;
repeated Literal constants = 7;
+ WindowExclusion exclude = 8;
Review Comment:
This extends the broker-to-server plan wire format without any mixed-version
guard. A newer broker can now serialize `exclude != EXCLUDE_NO_OTHERS` to an
older server, and that server will just ignore field 8 / the new enum and
execute legacy `NO_OTHERS` semantics. During a rolling upgrade that turns
`EXCLUDE CURRENT ROW/GROUP/TIES` into silently wrong results instead of a
rejected query, so this needs a capability/version gate or broker-side fallback
before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
