yashmayya commented on code in PR #18469:
URL: https://github.com/apache/pinot/pull/18469#discussion_r3237129199
##########
pinot-spi/pom.xml:
##########
@@ -290,7 +290,35 @@
</dependency>
<dependency>
<groupId>org.codehaus.groovy</groupId>
- <artifactId>groovy-all</artifactId>
+ <artifactId>groovy</artifactId>
Review Comment:
Good catch — you're right that the per-module list dropped real classes
(`CliBuilder` is in `groovy-cli-picocli` in 3.x, `JmxBuilder` in `groovy-jmx`),
and CI being green only proved the Pinot-Java surface, not customer transform
scripts.
Updated to `<type>pom</type>` + `<exclusions>` for just `groovy-testng` /
`groovy-test-junit5` / `groovy-test` — those three are what dragged in the
conflicting TestNG/JUnit jars that crashed Surefire's fork last time.
Everything else from the 2.4 fat-jar surface is back on the classpath. Verified
via `mvn dependency:tree`:
```
\- org.codehaus.groovy:groovy-all:pom:3.0.25:compile
+- groovy, groovy-ant, groovy-astbuilder, groovy-cli-picocli,
+- groovy-console, groovy-datetime, groovy-docgenerator,
+- groovy-groovydoc, groovy-groovysh, groovy-jmx, groovy-json,
+- groovy-jsr223, groovy-macro, groovy-nio, groovy-servlet,
+- groovy-sql, groovy-swing, groovy-templates, groovy-xml
```
(`groovy-testng`/`groovy-test-junit5`/`groovy-test` absent as expected.)
Locally re-ran the full `pinot-broker` test suite — no
`SurefireBooterForkException` / `NoClassDefFoundError` pattern from the
previous push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
