xiangfu0 commented on code in PR #18411:
URL: https://github.com/apache/pinot/pull/18411#discussion_r3199425596
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java:
##########
@@ -181,6 +183,8 @@ public EncodingType getEncodingType() {
@Nullable
Review Comment:
Fixed in 3558fc1246. The update diff now treats legacy
fieldConfigList[].indexType as unchanged when the stored JSON has an equivalent
singleton indexTypes array, with regression coverage for the idempotent and
non-equivalent cases.
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##########
@@ -212,6 +218,7 @@ public void setLoadMode(String loadMode) {
* {@link IngestionConfig#getStreamIngestionConfig()}
Review Comment:
Fixed in 3558fc1246. Restored @DeprecatedConfig on
IndexingConfig#getStreamConfigs now that the validator soft-launches parseable
deprecations as warnings, and added rule-discovery coverage for
tableIndexConfig.streamConfigs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
