xiangfu0 commented on code in PR #17167:
URL: https://github.com/apache/pinot/pull/17167#discussion_r3039172522
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotSchemaAdminClient.java:
##########
@@ -69,17 +76,32 @@ public String getSchemasInfo()
}
/**
- * Gets a specific schema by name.
+ * Gets a specific schema as a JSON string.
*
* @param schemaName Name of the schema
* @return Schema configuration as JSON string
* @throws PinotAdminException If the request fails
*/
- public String getSchema(String schemaName)
+ public String getSchemaString(String schemaName)
throws PinotAdminException {
JsonNode response = _transport.executeGet(_controllerAddress, "/schemas/"
+ schemaName, null, _headers);
return response.toString();
}
+ /**
+ * Gets a specific schema as a typed object.
+ * Prefer this method when you want to work with the Schema model directly.
+ * Use {@link #getSchemaString(String)} if you need the raw JSON.
+ *
+ * @param schemaName Name of the schema
+ * @return Pinot Schema object
+ * @throws PinotAdminException If the request fails
+ * @throws IOException If the response cannot be parsed as a Schema
+ */
+ public Schema getSchema(String schemaName)
Review Comment:
Done - removed deprecated `getSchemaString()`. `getSchema()` returns JSON
string, `getSchemaObject()` returns typed Schema.
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotSchemaAdminClient.java:
##########
@@ -69,17 +76,32 @@ public String getSchemasInfo()
}
/**
- * Gets a specific schema by name.
+ * Gets a specific schema as a JSON string.
*
* @param schemaName Name of the schema
* @return Schema configuration as JSON string
* @throws PinotAdminException If the request fails
*/
- public String getSchema(String schemaName)
+ public String getSchemaString(String schemaName)
Review Comment:
Done - `getSchema()` is the JSON string method (kept as-is), deprecated
`getSchemaString()` removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
