Copilot commented on code in PR #14698: URL: https://github.com/apache/pinot/pull/14698#discussion_r3012035745
########## pinot-core/src/test/java/org/apache/pinot/queries/InterSegmentNonBlockingGroupBySingleValueQueriesTest.java: ########## @@ -0,0 +1,293 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.queries; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import org.apache.pinot.common.response.broker.ResultTable; +import org.apache.pinot.common.utils.DataSchema; +import org.apache.pinot.common.utils.DataSchema.ColumnDataType; +import org.apache.pinot.core.plan.maker.InstancePlanMakerImplV2; +import org.testng.annotations.DataProvider; +import org.testng.annotations.Test; + + +/** + * Tests order by queries Review Comment: The class-level Javadoc ("Tests order by queries") is too generic/misleading for this new test; it specifically exercises inter-segment GROUP BY + ORDER BY behavior with the non-blocking combine operator enabled. Please update the comment to describe the actual coverage so it remains discoverable and accurate. ```suggestion * Tests inter-segment GROUP BY queries with ORDER BY when using the non-blocking combine operator. * Verifies ResultTable responses for both standard and trim-enabled execution paths. ``` ########## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/GroupByCombineOperator.java: ########## @@ -53,20 +53,22 @@ */ @SuppressWarnings("rawtypes") public class GroupByCombineOperator extends BaseSingleBlockCombineOperator<GroupByResultsBlock> { + public static final String ALGORITHM = "DEFAULT"; + Review Comment: The PR description lists additional changes (e.g., caching `Key.hashCode()` at construction and replacing `HashMap` with fastutil in `SimpleIndexedTable`) that don’t appear in the current code: `Key.hashCode()` still delegates to `Arrays.hashCode()` and `SimpleIndexedTable` still constructs a `HashMap`. Please either update the PR description to match what’s actually included, or add the missing changes if they’re still intended for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
