xiangfu0 commented on code in PR #17998:
URL: https://github.com/apache/pinot/pull/17998#discussion_r3006031034
##########
pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/TextIndexConfigTest.java:
##########
@@ -122,6 +116,15 @@ public void withSomeData()
assertEquals(config.getLuceneMaxBufferSizeMB(), 1024, "Unexpected
luceneMaxBufferSize");
}
+ @Test
+ public void withLegacyNativeFstTypeIgnored()
Review Comment:
This is still testing a dead config path. `TextIndexConfig` no longer binds
`fst`, and `FstIndexConfig` no longer binds `type`, so this only proves that
unknown JSON is ignored by Jackson. Pinot itself has no remaining behavior
behind these fields. Since we explicitly want to avoid tests on dead surface, I
would drop this case (and the matching one in `FstIndexConfigTest`) unless we
move the compatibility contract into explicit validation logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
