Jackie-Jiang opened a new pull request, #18012: URL: https://github.com/apache/pinot/pull/18012
## Summary - Add `getValueSize(int dictId)` to the `Dictionary` interface, returning the byte size of the stored value (for STRING: UTF-8 encoded length; for BIG_DECIMAL: serialized bytes length; for fixed-width types: the type's natural byte size via the default implementation) - Add `getValueSize(int index, int numBytesPerValue)` and `getUnpaddedValueSize(int index, int numBytesPerValue)` to the `ValueReader` interface, with implementations in `FixedByteValueReaderWriter` (returns `numBytesPerValue` / ZeroInWord scan) and `VarLengthValueReader` (reads from offset table) - Refactor `MutableColumnStatistics` and `IndexAndDictionaryBasedForwardIndexCreator` to use `getValueSize()` instead of allocating bytes just to measure their length - Implement `getValueSize()` across all immutable and mutable dictionary types (on-heap, off-heap, constant-value, same-value) ## Test plan - Added `getValueSize` assertions to `ImmutableDictionaryTest` for all dictionary types (INT, LONG, FLOAT, DOUBLE, BIG_DECIMAL, STRING, BYTES) - Added `testGetValueSize` to `FixedByteValueReaderWriterTest` covering both `getValueSize` and `getUnpaddedValueSize` - Added `getValueSize` / `getUnpaddedValueSize` assertions to `VarLengthValueReaderWriterTest` 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
