xiangfu0 opened a new pull request, #17999:
URL: https://github.com/apache/pinot/pull/17999
## Summary
- Move all dependency and plugin versions from module pom.xml files to the
root pom.xml `dependencyManagement`/`pluginManagement` sections
- Add Spark (core, sql, launcher), protobuf-dynamic, localstack-utils to
root `dependencyManagement`
- Add build-helper-maven-plugin to root `pluginManagement`
- Remove redundant `<version>` tags from 10 module pom.xml files
(pinot-arrow, pinot-kafka-3.0, pinot-integration-tests,
pinot-batch-ingestion-spark-3, pinot-spark-3-connector, pinot-tools,
pinot-protobuf, pinot-kinesis, pinot-controller, pinot-timeseries-m3ql)
## Documented Exceptions
Three version overrides must remain in modules (each has an XML comment
explaining why):
1. **pinot-kafka-4.0**: `kafka-clients` uses `${kafka4.version}` — targets
Kafka 4.x (different major version from root-managed Kafka 3.x)
2. **pinot-confluent-json**: `scala-library` uses `${scala-2.13.version}` —
Confluent's kafka-json-schema-serializer requires Scala 2.13 (rest of project
uses 2.12)
3. **pinot-common**: `fmpp` inside maven-antrun-plugin's `<dependencies>` —
plugin dependencies cannot use `dependencyManagement` (already centralized via
`${fmpp.version}` property)
## Out of Scope
- `contrib/pinot-druid-benchmark/pom.xml` — standalone project with
different groupId, not a Pinot module
## Test plan
- [ ] Verified all external dependencies resolve correctly via `mvn
help:effective-pom`
- [ ] Verified `mvn validate` passes on all modules
- [ ] CI build passes
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
