Copilot commented on code in PR #17860:
URL: https://github.com/apache/pinot/pull/17860#discussion_r2987803032
##########
helm/index.yaml:
##########
@@ -467,13 +497,13 @@ entries:
name: pinot-dev
name: presto
sources:
- - https://github.com/apache/pinot/tree/master/helm
+ - https://github.com/apache/incubator-pinot/tree/master/kubernetes/helm
urls:
- presto-0.2.1.tgz
version: 0.2.1
Review Comment:
The `presto` section in `index.yaml` still only lists `0.2.1`/`0.2.0` with
`apiVersion: v1`, but `helm/presto/Chart.yaml` was migrated to `apiVersion: v2`
and bumped to `0.2.2`. If `0.2.2` is intended to be published, add a
corresponding `presto-0.2.2.tgz` entry (with v2 metadata) and keep the older
entries unchanged; otherwise revert the presto version bump/migration from the
published repo.
##########
helm/pinot/Chart.yaml:
##########
@@ -17,19 +17,26 @@
# under the License.
#
-apiVersion: v1
+apiVersion: v2
+type: application
appVersion: 1.0.0
name: pinot
description: Apache Pinot is a realtime distributed OLAP datastore, which is
used to deliver scalable real time analytics with low latency. It can ingest
data from offline data sources (such as Hadoop and flat files) as well as
online sources (such as Kafka). Pinot is designed to scale horizontally.
-version: 0.3.6-SNAPSHOT
+version: 0.3.6
keywords:
- olap
- analytics
- database
- pinot
home: https://pinot.apache.org/
+icon: https://www.apache.org/logos/res/pinot/pinot.png
sources:
- https://github.com/apache/pinot/tree/master/helm
maintainers:
- name: pinot-dev
email: [email protected]
+dependencies:
+ - name: zookeeper
+ version: 13.x.x
+ repository: https://charts.bitnami.com/bitnami
+ condition: zookeeper.enabled,pinot.zookeeper.enabled
Review Comment:
The dependency `condition` order changed from the previous
`requirements.yaml` (`pinot.zookeeper.enabled,zookeeper.enabled`) to
`zookeeper.enabled,pinot.zookeeper.enabled`. Helm evaluates multiple condition
paths in order, so this can break backward compatibility for users still
setting `pinot.zookeeper.enabled` (it may be ignored if `zookeeper.enabled`
exists). Keep the original order or otherwise preserve compatibility for both
keys.
```suggestion
condition: pinot.zookeeper.enabled,zookeeper.enabled
```
##########
helm/presto/Chart.yaml:
##########
@@ -17,16 +17,18 @@
# under the License.
#
-apiVersion: v1
-appVersion: 0.2.2-SNAPSHOT
+apiVersion: v2
+type: application
+appVersion: 0.2.2
name: presto
description: Presto is an open source distributed SQL query engine for running
interactive analytic queries against data sources of all sizes ranging from
gigabytes to petabytes.
-version: 0.2.2-SNAPSHOT
+version: 0.2.2
Review Comment:
`version`/`appVersion` are bumped to `0.2.2`, but the repo artifacts aren’t
updated accordingly (there is no `helm/presto-0.2.2.tgz` and `helm/index.yaml`
doesn’t contain a `presto` entry for `0.2.2` or apiVersion `v2`). Either
add/package the new chart and update `index.yaml`, or keep `Chart.yaml` at the
last published version to avoid an inconsistent Helm repo.
##########
helm/index.yaml:
##########
@@ -1,37 +1,67 @@
apiVersion: v1
entries:
pinot:
+ - apiVersion: v2
+ appVersion: 1.0.0
+ created: "2026-03-18T10:19:29.386222157+02:00"
+ dependencies:
+ - condition: zookeeper.enabled,pinot.zookeeper.enabled
+ name: zookeeper
+ repository: https://charts.bitnami.com/bitnami
+ version: 13.x.x
+ description: Apache Pinot is a realtime distributed OLAP datastore, which
is used
+ to deliver scalable real time analytics with low latency. It can ingest
data
+ from offline data sources (such as Hadoop and flat files) as well as
online
+ sources (such as Kafka). Pinot is designed to scale horizontally.
+ digest: d1f164b3d5da3c0b075f261d1e6e46a9eb7309c338beae748749f829d76dfcae
+ home: https://pinot.apache.org/
+ icon: https://www.apache.org/logos/res/pinot/pinot.png
+ keywords:
+ - olap
+ - analytics
+ - database
+ - pinot
+ maintainers:
+ - email: [email protected]
+ name: pinot-dev
+ name: pinot
+ sources:
+ - https://github.com/apache/pinot/tree/master/helm
+ type: application
+ urls:
+ - pinot-0.3.6.tgz
+ version: 0.3.6
- apiVersion: v1
appVersion: 1.0.0
- created: "2025-10-08T22:20:54.54165-07:00"
+ created: "2026-03-18T10:19:29.37990297+02:00"
dependencies:
- - condition: pinot.zookeeper.enabled,zookeeper.enabled
- name: zookeeper
- repository: https://charts.bitnami.com/bitnami
- version: 13.x.x
+ - condition: pinot.zookeeper.enabled,zookeeper.enabled
+ name: zookeeper
+ repository: https://charts.bitnami.com/bitnami
+ version: 13.x.x
Review Comment:
`index.yaml` looks fully regenerated, which rewrites historical entries
(e.g., `created` timestamps and some `sources` URLs) for previously published
chart versions. Per `helm/README-dev.md` the generated index should be edited
to revert changes for older charts and keep their metadata stable. Consider
restoring the previous metadata for existing entries and only appending the new
release entries plus updating the final `generated` timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
