mluvin-stripe commented on code in PR #17862:
URL: https://github.com/apache/pinot/pull/17862#discussion_r2961738428
##########
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##########
@@ -232,6 +232,8 @@ public abstract class BaseControllerStarter implements
ServiceStartable {
protected TableSizeReader _tableSizeReader;
protected StorageQuotaChecker _storageQuotaChecker;
protected final List<UtilizationChecker> _utilizationCheckers = new
ArrayList<>();
+ protected DiskUtilizationChecker _diskUtilizationChecker;
Review Comment:
oh you're right, i'm not using it anywhere. let me remove it
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -386,6 +386,10 @@ public static long getRandomInitialDelayInSeconds() {
"controller.resource.utilization.checker.initial.delay";
public static final String RESOURCE_UTILIZATION_CHECKER_FREQUENCY =
"controller.resource.utilization.checker.frequency";
+ // Wait for the resource utilization checker to run once during controller
startup, before marking the controller
+ // as ready. When enabled,
controller.resource.utilization.checker.initial.delay is set to 0.
+ public static final String RESOURCE_UTILIZATION_CHECKER_WAIT_DURING_STARTUP =
+ "controller.resource.utilization.checker.waitDuringStartup";
Review Comment:
i think "run at startup" makes this seem equivalent to just setting
`controller.resource.utilization.checker.initial.delay = 0`, but it's actually
different since we're waiting for the checker to run before marking the
controller as healthy.
but lmk what you think, otherwise what do you think of
`controller.resource.utilization.checker.wait.for.completion.at.startup`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
