Jackie-Jiang commented on code in PR #17816:
URL: https://github.com/apache/pinot/pull/17816#discussion_r2961261616
##########
pinot-core/src/main/java/org/apache/pinot/core/query/prefetch/FetchPlanner.java:
##########
@@ -42,12 +44,13 @@ public interface FetchPlanner {
FetchContext planFetchForPruning(IndexSegment indexSegment, QueryContext
queryContext);
Review Comment:
We can do the same for this API
##########
pinot-core/src/main/java/org/apache/pinot/core/query/prefetch/DefaultFetchPlanner.java:
##########
@@ -89,8 +91,14 @@ protected static void extractEqInColumns(FilterContext
filter, Set<String> eqInC
* Fetch all kinds of index for columns accessed by the query.
*/
@Override
- public FetchContext planFetchForProcessing(IndexSegment indexSegment,
QueryContext queryContext) {
- return new FetchContext(UUID.randomUUID(), indexSegment.getSegmentName(),
getColumns(indexSegment, queryContext));
+ public List<FetchContext> planFetchForProcessing(List<SegmentContext>
segmentContexts, QueryContext queryContext) {
+ List<FetchContext> result = new ArrayList<>(segmentContexts.size());
+ for (SegmentContext segmentContext : segmentContexts) {
+ IndexSegment indexSegment = segmentContext.getIndexSegment();
+ result.add(
+ new FetchContext(UUID.randomUUID(), indexSegment.getSegmentName(),
getColumns(indexSegment, queryContext)));
+ }
+ return result;
}
private Set<String> getColumns(IndexSegment indexSegment, QueryContext
queryContext) {
Review Comment:
We want to process the columns before looping over all segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
