deepthi912 commented on code in PR #17503:
URL: https://github.com/apache/pinot/pull/17503#discussion_r2922507045
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/UpsertContext.java:
##########
@@ -192,6 +192,16 @@ public File getTableIndexDir() {
return _tableIndexDir;
}
+ /**
+ * Returns true if the table configuration has settings that can lead to
inconsistent upsert metadata
+ * during segment replacement after force commit. This happens when:
+ * - Partial upsert is enabled (records need to be merged with previous
values)
+ * - dropOutOfOrderRecord is enabled with NONE consistency mode (records may
have been dropped)
+ */
+ public boolean isTableTypeInconsistentDuringConsumption() {
Review Comment:
It might make more sense to rename this to
`isTableTypeInconsistentDuringConsumption` than
`requireConsistentMetadataDuringConsumption` for this method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
