gortiz commented on code in PR #17784:
URL: https://github.com/apache/pinot/pull/17784#discussion_r2919842626
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -160,11 +160,28 @@ default int getExceptionsSize() {
*/
boolean isMaxRowsInJoinReached();
+ /**
+ * Returns the max number of rows seen across all join operators.
+ */
+ long getMaxRowsInJoin();
+
Review Comment:
Do we need to add these methods to the interface? I don't see any call to
this, getMaxRowsInWindow or getNumGroups and it is not actually necessary for
jackson.
For example, getMaxRowsInOperator() is defined only for BrokerNativeV2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
