xiangfu0 commented on code in PR #17458:
URL: https://github.com/apache/pinot/pull/17458#discussion_r2676046735
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -820,20 +820,18 @@ private void reloadSegment(SegmentDataManager
segmentDataManager, IndexLoadingCo
// Use force commit to reload consuming segment
if (_instanceDataManagerConfig.shouldReloadConsumingSegment()) {
// For partial-upsert tables or upserts with out-of-order events
enabled, force-committing
- // consuming segments is disabled. In some cases (especially when
replication > 1), the
- // server that consumed fewer rows was incorrectly selected as the
winner, causing other
- // servers to reconsume rows and resulting in inconsistent data when
previous state must
- // be referenced for add/update operations.
- // TODO: Temporarily disabled until a proper fix is implemented.
+ // consuming segments is disabled by default. In some cases
(especially when replication > 1),
Review Comment:
fix the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
