yashmayya commented on code in PR #17419:
URL: https://github.com/apache/pinot/pull/17419#discussion_r2670489696


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -581,10 +587,19 @@ private BrokerResponse 
query(QueryEnvironment.CompiledQuery query, long requestI
       return new BrokerResponseNative(QueryErrorCode.EXECUTION_TIMEOUT);
     }
 
+    int stageCount = dispatchableSubPlan.getQueryStageMap().size();
+    int opChainCount = dispatchableSubPlan.getQueryStageMap().values().stream()
+        .mapToInt(stage -> stage.getServerInstances().size())

Review Comment:
   > You are right, but I didn't find that and it looks like right now we don't 
schedule more than one worker per server.
   
   It's possible when intermediate stage parallelism is configured via query 
option. There's some other scenarios too where more than one worker can be 
assigned to each server. 
   
   > Should I use stage.getWorkerMetadataList instead
   
   Yup, that's the right API to use here IMO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to