rhodo commented on code in PR #17457:
URL: https://github.com/apache/pinot/pull/17457#discussion_r2666795801
##########
pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java:
##########
@@ -76,6 +92,8 @@ default String toMetadataJsonString()
* This method ensures we emit metrics for all queries that have exceptions
with a one-to-one mapping.
*/
default void emitBrokerResponseMetrics(BrokerMetrics brokerMetrics) {
+ boolean isSystemError = false;
+ boolean isUserError = false;
Review Comment:
each metrics is 1:1 mapping, but system/user (critical/noncritical) is not
mutual exclusive as a query can contains multiple errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
