tibrewalpratik17 commented on code in PR #17352:
URL: https://github.com/apache/pinot/pull/17352#discussion_r2662374399
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java:
##########
@@ -240,10 +242,17 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
return pinotTaskConfigs;
}
+ /**
+ * Processes validDocIds metadata to determine segments eligible for
deletion or compaction.
+ * Evaluates segments based on valid/invalid document counts, server
readiness, and CRC consistency.
+ * Requires consensus across all replicas on validDoc counts before
proceeding with any operations.
+ * Marks segments with zero valid documents for deletion and groups others
by partition for compaction.
+ */
@VisibleForTesting
public static SegmentSelectionResult processValidDocIdsMetadata(String
tableNameWithType,
Map<String, String> taskConfigs, Map<String, SegmentZKMetadata>
candidateSegmentsMap,
- Map<String, List<ValidDocIdsMetadataInfo>> validDocIdsMetadataInfoMap,
Set<String> alreadyMergedSegments) {
+ Map<String, List<ValidDocIdsMetadataInfo>> validDocIdsMetadataInfoMap,
Set<String> alreadyMergedSegments,
+ ControllerMetrics controllerMetrics) {
Review Comment:
No need to pass controllerMetrics as a param. Can be accessed via
`_clusterInfoAccessor` in the method itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
