Copilot commented on code in PR #17291:
URL: https://github.com/apache/pinot/pull/17291#discussion_r2650760654
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/admin/PinotSegmentAdminClient.java:
##########
@@ -36,6 +38,10 @@ public class PinotSegmentAdminClient {
private final String _controllerAddress;
private final Map<String, String> _headers;
+ private static String encodePathSegment(String segment) {
+ return URLEncoder.encode(segment, StandardCharsets.UTF_8).replace("+",
"%20");
Review Comment:
The space-encoding workaround (`.replace("+", "%20")`) is applied here but
not in PinotSegmentApiClient's `encodePathSegment`. For consistency, both
implementations should use the same encoding strategy. Consider centralizing
this logic in a shared utility method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
