hongkunxu opened a new pull request, #17425:
URL: https://github.com/apache/pinot/pull/17425
Both pinot-core and pinot-common define a class named BasicAuthUtils, which
causes ambiguity in classes that need to use both utilities (e.g.
ZkBasicAuthAccessControlFactory).
An initial attempt was made to merge the two classes, but this proved
impractical due to Maven dependency constraints between pinot-core and
pinot-common.
Further analysis showed that the two classes serve different purposes:
• The BasicAuthUtils in pinot-core is used to extract and
construct BasicAuth principal information.
• The BasicAuthUtils in pinot-common is used to parse and handle
HTTP Basic Auth tokens.
To resolve the conflict and better reflect their responsibilities, this PR:
• Renames pinot-core’s BasicAuthUtils to
BasicAuthPrincipalExtractor
• Renames pinot-common’s BasicAuthUtils to BasicAuthTokenUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
