yashmayya commented on PR #17412: URL: https://github.com/apache/pinot/pull/17412#issuecomment-3687653840
@gortiz this change works regardless of whether we're using `GrpcBrokerRequestHandler` or `SingleConnectionBrokerRequestHandler` or `MultiStageBrokerRequestHandler`. If you're referring to the gRPC query server added to the broker in https://github.com/apache/pinot/pull/15088, that should be handled via the existing metrics defined here IMO - https://github.com/apache/pinot/blob/e5dba1966c9c3cd0a690ace61dc1758b7a7251aa/pinot-common/src/main/java/org/apache/pinot/common/metrics/BrokerMeter.java#L261-L265 Looks like `GRPC_BYTES_SENT` is defined but not currently being used, and we can fix that in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
