Akanksha-kedia opened a new pull request, #17394:
URL: https://github.com/apache/pinot/pull/17394
1. Root POM Configuration (pom.xml)
BEFORE:
<testcontainers.version>1.21.3</testcontainers.version>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers-bom</artifactId>
<version>${testcontainers.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
AFTER:
<testcontainers.version>2.0.0</testcontainers.version>
<!-- Removed testcontainers-bom dependency completely -->
Why This Change:
Version Consistency: Direct version control instead of BOM management
Conflict Prevention: Eliminates potential version conflicts from BOM
inheritance
Explicit Control: Each module now explicitly declares testcontainers versions
Security: Ensures all modules use the secure 2.0.0 version
2. Pinot Protobuf Module
(pinot-plugins/pinot-input-format/pinot-protobuf/pom.xml)
BEFORE:
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>kafka</artifactId>
<scope>test</scope>
</dependency>
AFTER:
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
<version>${testcontainers.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>kafka</artifactId>
<version>${testcontainers.version}</version>
<scope>test</scope>
</dependency>
Why This Change:
Explicit Versioning: No longer relies on BOM for version resolution
Build Stability: Prevents Maven from selecting wrong versions
Security Assurance: Guarantees 2.0.0 usage for test containers
3. Pinot S3 Module (pinot-plugins/pinot-file-system/pinot-s3/pom.xml)
BEFORE:
<dependency>
<groupId>com.adobe.testing</groupId>
<artifactId>s3mock-testcontainers</artifactId>
<version>${s3mock.version}</version>
<scope>test</scope>
</dependency>
AFTER:
<dependency>
<groupId>com.adobe.testing</groupId>
<artifactId>s3mock-testcontainers</artifactId>
<version>${s3mock.version}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
</exclusion>
</exclusions>
</dependency>
<!-- Add explicit testcontainers dependency with version 2.0.0 -->
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
<version>${testcontainers.version}</version>
<scope>test</scope>
</dependency>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
