Jackie-Jiang commented on code in PR #17357:
URL: https://github.com/apache/pinot/pull/17357#discussion_r2621698336
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -199,6 +201,14 @@ protected List<FieldConfig> getFieldConfigs() {
return fieldConfigs;
}
+ @Override
+ protected void overrideBrokerConf(PinotConfiguration brokerConf) {
+ super.overrideBrokerConf(brokerConf);
+ // Use IPv4 loopback explicitly to avoid 'localhost' IPv6 resolution
differences across environments for broker ->
Review Comment:
Can you explain more about this? Does this cause test failure/flakiness?
If so, should we modify the default url for test?
##########
pinot-plugins/assembly-descriptor/pom.xml:
##########
@@ -77,4 +77,19 @@
</plugin>
</plugins>
</build>
+
+ <profiles>
+ <profile>
+ <id>skip-invoker-its-when-skipTests</id>
Review Comment:
What is this for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
