Jackie-Jiang commented on code in PR #17364:
URL: https://github.com/apache/pinot/pull/17364#discussion_r2620996848
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/RoutingConfig.java:
##########
@@ -29,7 +29,7 @@ public class RoutingConfig extends BaseJsonConfig {
public static final String PARTITION_SEGMENT_PRUNER_TYPE = "partition";
public static final String TIME_SEGMENT_PRUNER_TYPE = "time";
public static final String EMPTY_SEGMENT_PRUNER_TYPE = "empty";
- public static final String DEFAULT_INSTANCE_SELECTOR_TYPE = "balanced";
+ public static final String BALANCED_INSTANCE_SELECTOR_TYPE = "balanced";
Review Comment:
Consider adding `public static final String DEFAULT_INSTANCE_SELECTOR_TYPE =
BALANCED_INSTANCE_SELECTOR_TYPE` so that it is backward compatible. We should
still use `DEFAULT_INSTANCE_SELECTOR_TYPE` when the config is missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
