Jackie-Jiang commented on code in PR #17355:
URL: https://github.com/apache/pinot/pull/17355#discussion_r2615258528
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/query/NonScanBasedAggregationOperator.java:
##########
@@ -248,36 +249,42 @@ private static Set getDistinctValueSet(Dictionary
dictionary) {
case INT:
IntOpenHashSet intSet = new IntOpenHashSet(dictionarySize);
for (int dictId = 0; dictId < dictionarySize; dictId++) {
+
QueryThreadContext.checkTerminationAndSampleUsagePeriodically(dictId,
EXPLAIN_NAME);
intSet.add(dictionary.getIntValue(dictId));
}
return intSet;
case LONG:
LongOpenHashSet longSet = new LongOpenHashSet(dictionarySize);
for (int dictId = 0; dictId < dictionarySize; dictId++) {
+
QueryThreadContext.checkTerminationAndSampleUsagePeriodically(dictId,
EXPLAIN_NAME);
longSet.add(dictionary.getLongValue(dictId));
}
return longSet;
Review Comment:
`BATCH_SIZE` is managed in the `QueryThreadContext` module. Do you see a way
that is both JIT friendly, and also hide the sampling logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
