krishan1390 commented on code in PR #17304: URL: https://github.com/apache/pinot/pull/17304#discussion_r2613283882
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/columntransformer/DataTypeColumnTransformer.java: ########## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.segment.local.columntransformer; + +import org.apache.pinot.common.utils.PinotDataType; +import org.apache.pinot.common.utils.ThrottledLogger; +import org.apache.pinot.segment.local.utils.DataTypeTransformerUtils; +import org.apache.pinot.spi.columntransformer.ColumnTransformer; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.ingestion.IngestionConfig; +import org.apache.pinot.spi.data.FieldSpec; +import org.apache.pinot.spi.data.readers.ColumnReader; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class DataTypeColumnTransformer implements ColumnTransformer { Review Comment: @9aman how and where is it allowed right now ? I don't understand any use case where we want this. DataTypeTransfomer is just converting source data type to destination data type If you mean ExpressionTransformer, where there can be a hierarchy thats a differnt use case. Even there, 1 column would apply 1 transformer just once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
