jadami-stripe commented on code in PR #17348:
URL: https://github.com/apache/pinot/pull/17348#discussion_r2608723943
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/value/LagValueWindowFunction.java:
##########
@@ -78,7 +78,9 @@ public List<Object> processRows(List<Object[]> rows) {
int numRows = rows.size();
Object[] result = new Object[numRows];
if (_defaultValue != null) {
- Arrays.fill(result, 0, _offset, _defaultValue);
+ // We only fill up to numRows to handle the case where the offset
+ // is larger than numRows
Review Comment:
ah you are right. Lookin at the line right below it, we proceed from _offset
to numRows to fill the rest of the values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
