krishan1390 commented on PR #17191: URL: https://github.com/apache/pinot/pull/17191#issuecomment-3626428296
> Going over the changes in `SegmentCreator` and the creation driver, I'd suggest keeping the segment name generation logic within the driver, and we can extract a pluggable segment name generator if necessary in the future. > > SegmentCreator: > > * Generate the indexes > * Convert the index format > * Generate creation metadata > > Driver: > > * Generate the segment name > * Move generated segment around > > This way we won't introduce incompatible changes, and we can keep the `seal()` method. > > As for the `InstanceType`, we can add a new `init()` method similar to how that is passed within the `SegmentIndexCreationDriverImpl` Done. 1. Driver will move the generated segment around. Though segment name is generated by the creator. 2. seal() method will create the final segment. 3. moved instanceType to init() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
