Akanksha-kedia commented on PR #17294: URL: https://github.com/apache/pinot/pull/17294#issuecomment-3611771092
Sure On Thu, 4 Dec 2025 at 2:41 PM, Abhishek Bafna ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > pinot-plugins/pinot-file-system/pinot-hdfs/src/main/java/org/apache/pinot/plugin/filesystem/HadoopPinotFS.java > <https://github.com/apache/pinot/pull/17294#discussion_r2588177361>: > > > @@ -88,6 +88,83 @@ public boolean delete(URI segmentUri, boolean forceDelete) > return _hadoopFS.delete(new Path(segmentUri), true); > } > > + @Override > > Please add test cases for all the public methods. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/pinot/pull/17294#pullrequestreview-3538863664>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AVL2AZQBR74LQDTVUDGCBSL3773F5AVCNFSM6AAAAACNVIM3JCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKMZYHA3DGNRWGQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
