anuragrai16 commented on code in PR #17264:
URL: https://github.com/apache/pinot/pull/17264#discussion_r2567321264


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/SegmentMetadataImpl.java:
##########
@@ -192,6 +193,13 @@ private void loadCreationMeta(File crcFile)
       final DataInputStream ds = new DataInputStream(new 
FileInputStream(crcFile));
       _crc = ds.readLong();
       _creationTime = ds.readLong();
+      try {
+        _dataCrc = ds.readLong();
+      } catch (IOException e) {
+        LOGGER.warn("Could not find data crc, falling back to default LONG_MIN 
value");

Review Comment:
   I've switched to a debug log for now. I think it might be useful specially 
in cases when replica segment might have data CRC and the other is an old 
segment that doesn't have it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to