Jackie-Jiang commented on code in PR #17249:
URL: https://github.com/apache/pinot/pull/17249#discussion_r2566494613
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -438,10 +442,10 @@ protected void
replaceSegmentIfCrcMismatch(SegmentDataManager segmentDataManager
_logger.info("Segment: {} has CRC: {} same as before, not replacing it",
segmentName, localMetadata.getCrc());
return;
}
- if (!_instanceDataManagerConfig.shouldCheckCRCOnSegmentLoad()) {
+ if (!_instanceDataManagerConfig.shouldCheckCRCOnSegmentLoad() ||
_skipCrcCheckForThisTable) {
Review Comment:
Per the intention of this flag, I think we should honor this flag on `add`,
`reload`, but not on `replace`. But this could cause another corner case: if a
segment is replaced when a server is down, it will be handled as `add` and then
cause stale segment.
Another way is to keep it as is, but we need mechanism to reject segment
replacement as it won't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
