Jackie-Jiang commented on code in PR #17168:
URL: https://github.com/apache/pinot/pull/17168#discussion_r2557932242
##########
pinot-common/src/main/proto/plan.proto:
##########
@@ -226,6 +227,21 @@ message ValueNode {
repeated LiteralRow literalRows = 1;
}
+message UnnestNode {
+ // Expression that evaluates to an array/multi-value to be unnested
+ Expression arrayExpr = 1;
Review Comment:
We need to make it a list
##########
pinot-common/src/main/proto/plan.proto:
##########
@@ -226,6 +227,21 @@ message ValueNode {
repeated LiteralRow literalRows = 1;
}
+message UnnestNode {
+ // Expression that evaluates to an array/multi-value to be unnested
+ Expression arrayExpr = 1;
+ // Optional output column alias for the element
+ string columnAlias = 2;
+ // Whether to output an ordinality column (1-based index per element)
+ bool withOrdinality = 3;
+ // Optional alias for the ordinality column
+ string ordinalityAlias = 4;
+ // Optional absolute output index of the element column in the stage schema
+ optional int32 elementIndex = 5;
+ // Optional absolute output index of the ordinality column in the stage
schema
+ optional int32 ordinalityIndex = 6;
Review Comment:
Per the documentation, these properties are associated with [Table
Functions](https://www.postgresql.org/docs/current/queries-table-expressions.html#QUERIES-TABLEFUNCTIONS).
Is it correct to have them as `UnnestNode` properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
