Jackie-Jiang opened a new issue, #17260: URL: https://github.com/apache/pinot/issues/17260
When multiple stream support was added in #13790, it assumes the partition id for a given stream can never go over `10000`. This assumption cannot be held for certain custom stream plugins. #15957 fixed the problem by always checking if it is single stream before applying the modulo operation in `IngestionConfigUtils` (`getStreamPartitionIdFromPinotPartitionId` and `getStreamConfigIndexFromPinotPartitionId`). Several recent PRs break this again, and we need to fix it: - #16783 @noob-se7en - #16833 @lnbest0707-uber - #17163 @noob-se7en - #17217 @tarun11Mavani In the meanwhile, we should consider adding a test for this scenario. @jadami10 Please confirm if you are still using a plugin that can generate large partition id -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
