Copilot commented on code in PR #17234:
URL: https://github.com/apache/pinot/pull/17234#discussion_r2547807779
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/ReloadJobStatus.java:
##########
@@ -52,9 +56,14 @@ public long getCreatedTimeMs() {
return _createdTimeMs;
}
+ public List<SegmentReloadFailureResponse> getFailedSegmentDetails() {
+ return _failedSegmentDetails;
Review Comment:
The getter returns the internal mutable list directly, allowing external
callers to modify the internal state. Return a defensive copy using
`Collections.unmodifiableList()` or `new ArrayList<>(_failedSegmentDetails)` to
prevent unintended modifications.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
