tibrewalpratik17 commented on code in PR #17126:
URL: https://github.com/apache/pinot/pull/17126#discussion_r2545909800
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -257,6 +257,13 @@ public static class UpsertCompactionTask {
* number of segments to query in one batch to fetch valid doc id
metadata, by default 500
*/
public static final String NUM_SEGMENTS_BATCH_PER_SERVER_REQUEST =
"numSegmentsBatchPerServerRequest";
+
+ /**
+ * Randomization factor for segment selection. If set to 2.0, will select
top (maxTasks * 2.0) segments
+ * as candidates, then randomly pick maxTasks from them. Default: 2.0 (2x
randomization)
+ */
+ public static final String SEGMENT_SELECTION_RANDOMIZATION_FACTOR =
"segmentSelectionRandomizationFactor";
+ public static final double DEFAULT_SEGMENT_SELECTION_RANDOMIZATION_FACTOR
= 2.0;
Review Comment:
Can we keep default as 1.0 to preserve backward compatibility of behaviour
plus keeping the goal to maximise compaction and reduction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
