jadami10 commented on code in PR #17200:
URL: https://github.com/apache/pinot/pull/17200#discussion_r2543894394
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -899,15 +911,15 @@ static void validateTTLForUpsertConfig(TableConfig
tableConfig, Schema schema) {
"MetadataTTL / DeletedKeysTTL does not work with multiple comparison
columns");
String comparisonColumn = comparisonColumns.get(0);
DataType comparisonColumnDataType =
schema.getFieldSpecFor(comparisonColumn).getDataType();
Review Comment:
I didn't do it this way because I couldn't convince myself if it was
fundamentally doing the same thing. I think it's minor enough that I prefer to
leave as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
