Copilot commented on code in PR #17221:
URL: https://github.com/apache/pinot/pull/17221#discussion_r2539505658
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/tls/RenewableTlsUtils.java:
##########
@@ -227,8 +231,9 @@ static void
enableAutoRenewalFromFileStoreForSSLFactory(SSLFactory sslFactory, S
// it was never detected and run in others. This will result in few
components with
// stale certificates. In order to prevent this issue, we are adding a
new scheduled
// thread which will run once a day and reload the certs.
-
- Executors.newSingleThreadScheduledExecutor().scheduleAtFixedRate(() -> {
+ // Use daemon thread to allow JVM to exit when on-demand processes
complete.
+ Executors.newSingleThreadScheduledExecutor(new
NamedThreadFactory(SSL_DAILY_RELOAD_THREAD_PREFIX, true))
+ .scheduleAtFixedRate(() -> {
Review Comment:
The indentation on line 236 is inconsistent with the rest of the codebase.
The `.scheduleAtFixedRate` method call should align with the opening
parenthesis on line 235 or use standard 4-space indentation.
```suggestion
.scheduleAtFixedRate(() -> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
